Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(jsonc): added jsonc support #1234

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat(jsonc): added jsonc support #1234

wants to merge 5 commits into from

Conversation

shubhexists
Copy link
Contributor

@shubhexists shubhexists commented Dec 3, 2024 •
edited
Loading

Fixes #1189

Added jsonc support for deno.jsonc

PR Checklist

  • Docs are updated if needed
  • Tests are added/updated if needed

@coffee-cup coffee-cup added the release/minor Author minor release label Dec 9, 2024
coffee-cup
coffee-cup approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@coffee-cup coffee-cup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just the one printlnt that should be removed

src/nixpacks/app.rs Outdated Show resolved Hide resolved
@shubhexists
Copy link
Contributor Author

Oops missed it ! Removed the println
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coffee-cup coffee-cup coffee-cup approved these changes

Assignees
No one assigned
Labels
release/minor Author minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nixpacks Bug Report: jsonc is parsed as json
2 participants
@shubhexists @coffee-cup